fix(tui): align skill descriptions with wide characters - #42262
Open
liujianbo2013 wants to merge 2 commits into
Open
fix(tui): align skill descriptions with wide characters#42262liujianbo2013 wants to merge 2 commits into
liujianbo2013 wants to merge 2 commits into
Conversation
Update maxWidth calculation to use Bun.stringWidth for accurate width measurement.
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(tui): align skill descriptions with wide characters
Issue for this PR
#40605
Closes #40605
Type of change
What does this PR do?
When a skill's name contains wide characters (e.g. CJK), the
/skillsdialog padded titles withString.prototype.padEndbased on UTF-16 codeunit length (s.name.length). Chinese characters count as 1 code unit butoccupy 2 terminal cells, so titles with the same code-unit length ended atdifferent screen columns and the descriptions below them misaligned.The fix measures the column width with
Bun.stringWidth(already usedelsewhere in the TUI, e.g.src/prompt/display.ts) and pads each title upto the maximum display width instead of the maximum code-unit length:How did you verify your code works?
I created a Chinese title skill that describes normal alignment
Screenshots / recordings
Checklist
If you do not follow this template your PR will be automatically rejected.