fix(shell): encode PowerShell commands to preserve multi-line output - #42274
Open
vladislav-miroshnikov wants to merge 2 commits into
Open
fix(shell): encode PowerShell commands to preserve multi-line output#42274vladislav-miroshnikov wants to merge 2 commits into
vladislav-miroshnikov wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41983
Type of change
What does this PR do?
On Windows, a configured PowerShell
.cmdor.batwrapper passes throughcmd.exe, which treats newlines in a-Commandargument as command separators. Only the first line can reach PowerShell.This uses PowerShell's UTF-16LE
-EncodedCommandform for wrapper scripts, while preserving-Commandfor directpowershell.exeandpwsh.exeexecutables. That keeps multiline wrapper commands intact without reducing the command-line budget for direct executables.How did you verify your code works?
cd packages/opencode && bun test test/tool/shell.test.ts— 24 pass, 0 failcd packages/core && bun test test/shell.test.ts— 7 pass, 0 failcd packages/opencode && bun typecheckcd packages/core && bun typecheckPortable tests verify the exact argument form and UTF-16LE round trip. A Windows-only test creates a real
pwsh.cmdwrapper and verifies all three lines of a multiline command reach PowerShell.Screenshots / recordings
N/A — no UI change.
Checklist