fix(opencode): filter compaction events from jsonl output - #42316
Open
vladislav-miroshnikov wants to merge 1 commit into
Open
fix(opencode): filter compaction events from jsonl output#42316vladislav-miroshnikov wants to merge 1 commit into
vladislav-miroshnikov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #42238
Type of change
What does this PR do?
When auto-compaction occurs,
opencode run --format jsonemits internal compaction output (summaries, step events, reasoning) as ordinary JSONL events. Consumers cannot distinguish these from user-visible assistant output.The fix tracks compaction message IDs from
message.updatedevents (whereinfo.mode === "compaction") and skips all parts belonging to those messages. Synthetic continuation prompts are also filtered viapart.synthetic.How did you verify your code works?
All 13 existing
run-process.test.tstests pass with no regression.bun typecheckpasses clean. ThecompactionMessagesSet is populated frommessage.updatedwhich fires before anymessage.part.updatedfor the same message (sequential publish in the same Effect fiber), so the filter is always in place before parts arrive.A dedicated compaction test would require triggering real context overflow in the subprocess harness, which is complex with the mock LLM server. The fix was verified manually against the issue's reproduction steps.
Checklist