fix(opencode): remove Qwen sampling defaults - #43310
Merged
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
temperature: 0.55andtop_p: 1for every Qwen modelchat.paramsplugins can still override all sampling controlsWhy
Qwen sampling recommendations now vary by model family and thinking mode, so the blanket name-based defaults are stale and can override better provider-side settings, especially for custom and local endpoints.
Fixes #42775
Testing
bun test test/provider/transform.test.ts(411 pass)git diff --checkbun typecheckattempted, buttsgowas terminated by shared-host resource exhaustionRequested by: @rekram1-node (Aiden via Slack)