fix: merge plugin selections (resolves #4565)#4724
Conversation
There was a problem hiding this comment.
can we undo this? Whyd we change it
|
2 nits but looks good |
|
Not sure why or how that file changed, I will revert it back to match HEAD. |
|
Done. |
|
/oc update the plugin merging so that it uses a set to prevent duplicates |
|
Excellent! All typechecks pass. Let me create a summary of what was changed: SummaryI've successfully updated the plugin merging logic in Changes MadeFile:
File:
Benefits
Verification
The change is minimal, focused, and maintains the existing plugin merging behavior while adding deduplication to prevent duplicates as requested. |
Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
|
Thank you! |
Co-authored-by: Dax Raad <d@ironbay.co> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
Co-authored-by: Dax Raad <d@ironbay.co> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
Co-authored-by: Dax Raad <d@ironbay.co> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
Co-authored-by: Dax Raad <d@ironbay.co> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
Co-authored-by: Dax Raad <d@ironbay.co> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
Co-authored-by: Dax Raad <d@ironbay.co> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>

Resolves #4565.
I stumbled onto a version of 4565 myself while I was messing around editing opencode's source: when I launched opencode in it's own source directory, my bell plugin at
~/.config/opencode/plugin/bell.ts(just plays a sound when the session idles, nothing fancy) stopped making noise. After poking around a bit, I discovered that this was a consequence ofopencode/.opencode/opencode.jsoncspecifying plugin selections, which were replacing (instead of being combined with) my own globally selected plugins.This PR fixes that, merging the globally selected plugins with those selected locally in the project.