feat: toggle tool details visibility (resolves #4824)#4882
Conversation
… "Show action blocks" depending on current state
d7c52fc to
e80d742
Compare
|
@rekram1-node Tidied up that spurious line you'd drawn my attention to. This should probably be good to go now, I think? |
|
@rekram1-node Seems like most of that can go. Temporarily reverting to draft status while I finish tidying it up. |
The hiding logic only needs to check for pending permissions, not historical tracking of tools that asked for permission. Once a tool completes successfully, whether it required permission is irrelevant to the hiding decision.
- Add hideDetails to BasicToolProps interface - Restore !props.hideDetails condition for Collapsible.Arrow visibility - Ensures proper tool hiding functionality works correctly
…tsx were in fact unnecessary, resync with dev
…e-tool-action-visibility
|
@rekram1-node Tidied up, the changes should be nice and lean now. :) |
|
/oc rename the things in this pr called "tool usage" to "tool details" |
|
Done! I've renamed all instances of "tool usage" to "tool details" in the PR:
The changes are now consistent throughout the file, and the feature will persist visibility state to |
Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
|
/oc rename showActions to showDetails, also if shouldHide is true return undefined instead of null |
|
Perfect! I've successfully completed all the requested changes:
The changes maintain consistency with the PR's goal of managing tool details visibility, and TypeScript compilation passes without errors. |
Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
…lyco#4882) Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
…lyco#4882) Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
…lyco#4882) Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
…lyco#4882) Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
…lyco#4882) Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
…lyco#4882) Co-authored-by: GitHub Action <action@github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>


Resolves #4824.
Successful tool calls can be hidden.
Unsuccessful tool calls are always displayed so that any error messages can be seen,
The modal used by the "ask" permission is NOT hidden.
In the
command_list, the command's name is eitherHide tool usageorShow tool usage, depending on its current state.The current state of the toggle is persisted to
kv.jsonastool_usage_visibility.