fix(provider): harden Claude tool-call adjacency normalization#5719
Closed
chrisolszewski wants to merge 5 commits into
Closed
fix(provider): harden Claude tool-call adjacency normalization#5719chrisolszewski wants to merge 5 commits into
chrisolszewski wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Anthropic API 400 errors caused by incorrect message adjacency when using tool calls. Anthropic requires that tool calls in an assistant message be the last content blocks (terminal tool calls). This PR implements a "Terminal Suffix" strategy to strictly enforce this.
Key Changes
sanitizeToolPartsto avoid ID collisions using aMap+ base64url fallback, ensuring uniqueness even when sanitization modifies IDs.isToolCallPart) to reject malformed arrays and require valid tool names.Verification
packages/opencode/test/provider/transform.test.ts: Added coverage for split/duplicate/partial results, ID collision avoidance, and idempotence.packages/opencode/test/provider/anthropic-regression.test.ts: Added regression test matching the specific failure shape (tool call followed by text).