Conversation
The read tool's display in the share view was unintentionally falling back to rendering the full tool output if the specific metadata.preview (max 20 lines) was an empty string. This could lead to more data being embedded in the page source than implied by the UI. This commit modifies the Share.tsx component to ensure that the CodeBlock for the read tool prioritizes metadata.preview even if it's an empty string. The fallback to showing the full tool result via TextPart is now more restrictive and less likely to be triggered for the read tool, thus preventing excessive data exposure in the preview.
ghost
deleted the
fix/share-data-exposure
branch
July 3, 2025 04:42
achembarpu
pushed a commit
to achembarpu/opencode
that referenced
this pull request
Aug 4, 2025
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Jun 10, 2026
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read tool's display in the share view was unintentionally falling back to rendering the full tool output if the specific metadata.preview (max 20 lines) was an empty string. This could lead to more data being embedded in the page source than implied by the UI.
This commit modifies the Share.tsx component to ensure that the CodeBlock for the read tool prioritizes metadata.preview even if it's an empty string. The fallback to showing the full tool result via TextPart is now more restrictive and less likely to be triggered for the read tool, thus preventing excessive data exposure in the preview.