fix(desktop): use current_binary() to support symlinked executables #7102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace tauri::utils::platform::current_exe() with tauri::process::current_binary() in get_sidecar_path() to resolve symlinks properly. Fixes crash when running from Nix store paths or other symlinked installations.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash when the desktop app is launched from symlinked executables (such as Nix store paths) by replacing tauri::utils::platform::current_exe() with tauri::process::current_binary() in the get_sidecar_path() function.
Key Changes:
- Update to use
tauri::process::current_binary()which properly resolves symlinks instead of rejecting them
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@adamdotdevin, ouch, triggers a build failure, missing |
jerome-benoit
added a commit
to jerome-benoit/opencode
that referenced
this pull request
Jan 6, 2026
…or PRs Follow-up to anomalyco#7102 which was merged incomplete: - Use tauri::process::current_binary() instead of tauri::utils::platform::current_exe() - Pass AppHandle to get_sidecar_path() to provide required &Env parameter - Update install_cli() and sync_cli() to pass AppHandle through call chain - Enable nix-desktop workflow on pull_request events for same paths as push
jerome-benoit
added a commit
to jerome-benoit/opencode
that referenced
this pull request
Jan 6, 2026
…or PRs - Fix get_sidecar_path() to use tauri::process::current_binary(&app.env()) - Pass AppHandle through the call chain to support the new API - Add Manager trait import for app.env() access - Enable pull_request trigger in nix-desktop workflow for CI on PRs This completes the fix from PR anomalyco#7102 which was merged with compilation errors.
jerome-benoit
added a commit
to jerome-benoit/opencode
that referenced
this pull request
Jan 6, 2026
…or PRs - Fix get_sidecar_path() to use tauri::process::current_binary(&app.env()) - Pass AppHandle through the call chain to support the new API - Add Manager trait import for app.env() access - Enable pull_request trigger in nix-desktop workflow for CI on PRs This completes the fix from PR anomalyco#7102 which was merged with compilation errors.
jerome-benoit
added a commit
to jerome-benoit/opencode
that referenced
this pull request
Jan 6, 2026
…or PRs - Fix get_sidecar_path() to use tauri::process::current_binary(&app.env()) - Pass AppHandle through the call chain to support the new API - Add Manager trait import for app.env() access - Enable pull_request trigger in nix-desktop workflow for CI on PRs This completes the fix from PR anomalyco#7102 which was merged with compilation errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
tauri::utils::platform::current_exe()withtauri::process::current_binary()inget_sidecar_path()to resolve symlinks properly.Fixes crash when running from Nix store paths or other symlinked installations.
Changes
packages/desktop/src-tauri/src/cli.rs: Usetauri::process::current_binary()instead oftauri::utils::platform::current_exe()Context
The previous implementation rejected symlinked executables on macOS/Windows for security reasons, causing crashes when the desktop app was installed via Nix or other package managers that use symlinks.