Skip to content

Conversation

@jerome-benoit
Copy link
Contributor

@jerome-benoit jerome-benoit commented Jan 6, 2026

Summary

Changes

  • packages/desktop/src-tauri/src/cli.rs:

    • Add use tauri::Manager; import for .env() access
    • Change get_sidecar_path() to accept app: &tauri::AppHandle parameter
    • Use tauri::process::current_binary(&app.env()) instead of current_exe()
    • Update install_cli() to pass through AppHandle
  • packages/desktop/src-tauri/src/lib.rs:

    • Pass app parameter to get_sidecar_path(app) call
  • .github/workflows/nix-desktop.yml:

    • Add pull_request trigger to enable CI on PRs

Context

PR #7102 was merged but had a compilation error because tauri::process::current_binary() requires a parameter. This PR fixes that issue by properly passing the app environment through the call chain.

Testing

  • CI builds will validate the fix compiles on Ubuntu and macOS

Completes #7102

Copilot AI review requested due to automatic review settings January 6, 2026 19:05
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the symlink support implementation from PR #7102, which was merged with compilation errors. It updates the get_sidecar_path() function to use tauri::process::current_binary() with proper parameter passing through the call chain, and enables PR CI checks for the nix-desktop workflow.

Key Changes

  • Modified get_sidecar_path() to accept AppHandle parameter and use tauri::process::current_binary(app.env()) for symlink resolution
  • Updated install_cli() to accept and pass through AppHandle to get_sidecar_path()
  • Added pull_request trigger to nix-desktop workflow to enable CI on PRs

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/desktop/src-tauri/src/cli.rs Updated function signatures to accept and pass AppHandle for proper symlink resolution using tauri::process::current_binary()
packages/desktop/src-tauri/src/lib.rs Updated call to get_sidecar_path() to pass the app parameter
.github/workflows/nix-desktop.yml Added pull_request trigger with path filters to enable CI checks on PRs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jerome-benoit jerome-benoit force-pushed the fix/desktop-symlink-support-clean branch from 42654f3 to 4b2bbf1 Compare January 6, 2026 19:09
…or PRs

- Fix get_sidecar_path() to use tauri::process::current_binary(&app.env())
- Pass AppHandle through the call chain to support the new API
- Add Manager trait import for app.env() access
- Enable pull_request trigger in nix-desktop workflow for CI on PRs

This completes the fix from PR anomalyco#7102 which was merged with compilation errors.
@jerome-benoit jerome-benoit force-pushed the fix/desktop-symlink-support-clean branch from 4b2bbf1 to bc7f679 Compare January 6, 2026 19:11
@Marve10s
Copy link

Marve10s commented Jan 6, 2026

Did you trigger the checks by yourself? Just curious

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Hey! Your PR title fix(desktop): complete symlink support implementation and enable CI for PRs doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: new feature
  • fix: bug fix
  • docs: documentation changes
  • chore: maintenance tasks
  • refactor: code refactoring
  • test: adding or updating tests

See CONTRIBUTING.md for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@Brendonovich Brendonovich merged commit b1e381c into anomalyco:dev Jan 9, 2026
4 of 5 checks passed
@jerome-benoit jerome-benoit deleted the fix/desktop-symlink-support-clean branch January 9, 2026 15:07
aryasaatvik pushed a commit to aryasaatvik/opencode that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants