-
Notifications
You must be signed in to change notification settings - Fork 5k
fix(desktop): complete symlink support implementation and enable CI for PRs #7113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(desktop): complete symlink support implementation and enable CI for PRs #7113
Conversation
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR completes the symlink support implementation from PR #7102, which was merged with compilation errors. It updates the get_sidecar_path() function to use tauri::process::current_binary() with proper parameter passing through the call chain, and enables PR CI checks for the nix-desktop workflow.
Key Changes
- Modified
get_sidecar_path()to acceptAppHandleparameter and usetauri::process::current_binary(app.env())for symlink resolution - Updated
install_cli()to accept and pass throughAppHandletoget_sidecar_path() - Added
pull_requesttrigger to nix-desktop workflow to enable CI on PRs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/desktop/src-tauri/src/cli.rs | Updated function signatures to accept and pass AppHandle for proper symlink resolution using tauri::process::current_binary() |
| packages/desktop/src-tauri/src/lib.rs | Updated call to get_sidecar_path() to pass the app parameter |
| .github/workflows/nix-desktop.yml | Added pull_request trigger with path filters to enable CI checks on PRs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
42654f3 to
4b2bbf1
Compare
…or PRs - Fix get_sidecar_path() to use tauri::process::current_binary(&app.env()) - Pass AppHandle through the call chain to support the new API - Add Manager trait import for app.env() access - Enable pull_request trigger in nix-desktop workflow for CI on PRs This completes the fix from PR anomalyco#7102 which was merged with compilation errors.
4b2bbf1 to
bc7f679
Compare
|
Did you trigger the checks by yourself? Just curious |
|
Hey! Your PR title Please update it to start with one of:
See CONTRIBUTING.md for details. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Summary
get_sidecar_path()to usetauri::process::current_binary(&app.env())Changes
packages/desktop/src-tauri/src/cli.rs:
use tauri::Manager;import for.env()accessget_sidecar_path()to acceptapp: &tauri::AppHandleparametertauri::process::current_binary(&app.env())instead ofcurrent_exe()install_cli()to pass throughAppHandlepackages/desktop/src-tauri/src/lib.rs:
appparameter toget_sidecar_path(app)call.github/workflows/nix-desktop.yml:
pull_requesttrigger to enable CI on PRsContext
PR #7102 was merged but had a compilation error because
tauri::process::current_binary()requires a parameter. This PR fixes that issue by properly passing the app environment through the call chain.Testing
Completes #7102