fix(deps): bump serialize-javascript to 7.0.5 (high-severity RCE/DoS)#124
Merged
Conversation
Resolves high-severity RCE (CVE-2026-34043) and CPU-exhaustion DoS. Forced via overrides because mocha pins ^6.0.2. Rebased onto main to combine with the existing undici override.
anoncam
force-pushed
the
fix/deps-serialize-javascript
branch
from
fed25de to
85c1801
Compare
github-actions Bot
added a commit
that referenced
this pull request
Jun 2, 2026
Version bump type: patch PR: #124 Title: fix(deps): bump serialize-javascript to 7.0.5 (high-severity RCE/DoS)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forces
serialize-javascriptto 7.0.5 via anoverridesentry, resolving:RegExp.flags/Date.prototype.toISOString()Target version confirmed by Sonatype (trust score 98, no remaining vulns).
Why an override
serialize-javascriptis pulled only bymocha@^6.0.2(devDependency), which pins the^6major. A plainnpm updatecan't cross to 7.x, so anoverridesentry is required to force the patched major.Risk assessment
Low.
serialize-javascriptis used by mocha solely to serialize data across parallel test workers. This project's test script (mocha test/**/*.test.js) runs serially — no--parallelflag — so the package is never invoked at runtime. The override only improves the dependency tree's security posture.Verification
npm run build✅ passesnpm test: no regression — failures are confined to the pre-existing flaky friend-encryption / PGP suites (verified identical onmainacross multiple runs; which ones fail varies due to key-generation entropy).Note
Touches the same
overridesblock as #123 (undici). Whichever merges second will need a trivial rebase to combine the two override keys.