Skip to content

Add form validation to login #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anoopcodehack merged 2 commits into from
Jul 31, 2026
Merged

Add form validation to login #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b90c74
Add form validation to login (fixes #102)
rimshashafique19 Jul 31, 2026
c1be478
Update package-lock.json
rimshashafique19 Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions devboard/client/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 29 additions & 8 deletions devboard/client/src/pages/Login.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ const Login = () => {

const handleSubmit = async () => {
setError("");

if (isRegister && !form.name.trim()) return setError("Name is required");
if (!form.email.includes("@")) return setError("Enter a valid email");
if (form.password.length < 6)
return setError("Password must be at least 6 characters");

if (!form.email || !form.password || (isRegister && !form.name)) {
setError("Please fill in all required fields");
return;
Expand All @@ -27,9 +33,13 @@ const Login = () => {
setLoading(true);
try {
const endpoint = isRegister ? "/api/auth/register" : "/api/auth/login";

const payload = isRegister
? { name: form.name.trim(), email: form.email.trim(), password: form.password }
? {
name: form.name.trim(),
email: form.email.trim(),
password: form.password,
}
: { email: form.email.trim(), password: form.password };

const { data } = await axios.post(endpoint, payload);
Expand All @@ -42,9 +52,12 @@ const Login = () => {
// 2. Clear error & Direct Navigate to Dashboard Route "/"
setError("");
navigate("/", { replace: true }); // <-- 3. Router navigate call!

} catch (err) {
setError(err.response?.data?.message || err.response?.data?.error || "Something went wrong");
setError(
err.response?.data?.message ||
err.response?.data?.error ||
"Something went wrong",
);
} finally {
setLoading(false);
}
Expand All @@ -61,7 +74,9 @@ const Login = () => {
<div className="text-center mb-8">
<div className="text-4xl mb-2">🗂️</div>
<h1 className="text-2xl font-bold text-[#f0f0f0]">DevBoard</h1>
<p className="text-[#666] text-sm mt-1">Kanban built for developers</p>
<p className="text-[#666] text-sm mt-1">
Kanban built for developers
</p>
</div>

<div className="bg-[var(--bg-card)] border border-[var(--border-primary)] rounded-xl p-6 flex flex-col gap-3">
Expand Down Expand Up @@ -108,20 +123,26 @@ const Login = () => {
disabled={loading}
className="w-full py-2.5 bg-purple-600 hover:bg-purple-500 text-white rounded-lg text-sm font-medium transition disabled:opacity-40"
>
{loading ? "Please wait..." : isRegister ? "Create Account" : "Sign In"}
{loading
? "Please wait..."
: isRegister
? "Create Account"
: "Sign In"}
</button>

<button
type="button"
onClick={toggleMode}
className="text-xs text-[#666] hover:text-[#aaa] transition text-center mt-1"
>
{isRegister ? "Already have an account? Sign in" : "No account? Register"}
{isRegister
? "Already have an account? Sign in"
: "No account? Register"}
</button>
</div>
</div>
</div>
);
};

export default Login;
export default Login;