Fix user pagination schema field names - #172
Merged
Merged
Conversation
…e removal Adds regression coverage for the user.* pagination field rename (pages/perPages -> page/perPage) across getLovedTracks, getRecentTracks, getTopAlbums, getTopArtists, and getTopTracks, plus a schema-level assertion that userGetTopTagsRequestSchema strips the unsupported page parameter.
ansango
approved these changes
Sep 4, 2026
Owner
|
Thanks @corygibbons for catching this — the rename is spot on, and I added regression tests (6 new cases covering all five renamed endpoints + the |
Patch release for PR ansango#172: rename user pagination @attr fields from pages/perPages to page/perPage (matching the Last.fm wire format) and drop the unsupported page parameter from user.getTopTags.
ansango
approved these changes
Sep 4, 2026
Contributor
Author
|
@ansango, no worries. Thanks for the library, saved me a bunch of time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few things:
pagesandperPagesresponse fields withpageandperPagefieldspageparameter fromuser.getTopTags