You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Minor Changes
Add significant number of testcases across multiple modules that were not covered due to which sonar coverage failures were being caused
All legacy modules - add emit_warnings() call from ansible_collections.ansible.netcommon.plugins.module_utils.network.common.utils before module.exit_json() to pop and emit the warnings key via module.warn(), suppressing the deprecation warning raised by ansible-core 2.23+.
All legacy modules that already imported from ansible_collections.ansible.netcommon.plugins.module_utils.network.common.utils - extend the existing import block to include emit_warnings.
The following files - plugins/cliconf/nxos.py, plugins/httpapi/nxos.py, plugins/module_utils/network/nxos/nxos.py, plugins/module_utils/network/nxos/facts/snmp_server/snmp_server.py - replace deprecated ansible.module_utils._text and ansible.module_utils.common._collections_compat imports with their modern equivalents (ansible.module_utils.common.text.converters and collections.abc).
nxos_hsrp_interfaces - In replaced and overridden states, negate removed sub-options for preempt before applying the desired configuration. This aligns command generation with NX-OS additive CLI behavior when only part of a preempt delay setting is specified.
Bugfixes
Fix nxos_nxapi integration test assertions to use boolean conditions compatible with ansible-core 2.19+.
Fix nxos_static_routes rtt integration test assert missing in result.commands for ansible-core 2.19+.
Fix nxos_telemetry integration test asserts to use boolean Jinja expressions without template delimiters for ansible-core 2.19+.
Fix nxos_user auth integration test assert for results.failed.
Fix nxos_user basic integration test weak-password warnings assertions to be conditional on warnings presence for ansible-core 2.21+.
nxos_facts - fix KeyError when show interface text output has admin preamble before the first interface on multi-module chassis (#1076).
nxos_hsrp_interfaces - Update preempt and priority templates to render optional sub-options independently, enabling per-key command generation.
nxos_l2_interfaces - Fix replaced and overridden states for trunk allowed VLANs to set the full desired VLAN list instead of incremental add/remove.
nxos_lag_interfaces - fix 'NoneType' object is not iterable when using replaced state on a port-channel with no members (#819).