Skip to content

Conversation

@AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Jun 6, 2025

I seized the oportunity to migrate from os to pathlib and add all missing docstrings.

@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review June 6, 2025 11:46
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes - let's hold off from merging this one anyways for now. And talk with the rest of the team before doing so.

@RobPasMue RobPasMue linked an issue Jun 9, 2025 that may be closed by this pull request
2 tasks
@RobPasMue
Copy link
Member

Once #25 is merged, let's update this PR and have it merged

@RobPasMue
Copy link
Member

Make sure to port the last changes (if any) from ansys-tools-path

@AlejandroFernandezLuces
Copy link
Contributor Author

The only update in latest release other than dependency bumps and workflow maintenance seems to only be adding the 261 entry in the installations versions dir.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments - LGTM! Thanks @AlejandroFernandezLuces

@AlejandroFernandezLuces AlejandroFernandezLuces merged commit f3de8be into main Jun 26, 2025
15 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the feat/add-tools-path branch July 28, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transfer ansys-tools-path project into ansys-tools-common

3 participants