Skip to content

Conversation

@jorgepiloto
Copy link
Member

@jorgepiloto jorgepiloto commented Jul 15, 2022

Solves for #143 by forcing a white background in mermaid diagrams.

@github-actions github-actions bot added documentation Improvements or additions to documentation bug Something isn't working labels Jul 15, 2022
@jorgepiloto
Copy link
Member Author

Forcing a white background in graphviz diagrams too.

@jorgepiloto jorgepiloto requested review from RobPasMue and da1910 July 15, 2022 19:17
@jorgepiloto jorgepiloto marked this pull request as ready for review July 15, 2022 19:48
@jorgepiloto jorgepiloto changed the title Force white background in mermaid diagrams Force white background in diagrams Jul 15, 2022
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my recommendation, LGTM!

@jorgepiloto jorgepiloto merged commit e1b46ba into main Jul 16, 2022
@jorgepiloto jorgepiloto deleted the fix/diagrams branch July 16, 2022 14:30
@MaxJPRey MaxJPRey linked an issue Jul 17, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poor Appearence of Diagrams with Dark Mode

3 participants