Skip to content

Wrong scripting name in ResultInfo #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

Wrong scripting name in ResultInfo #2245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9f4ee7
Wrong scripting name
cbellot000 Apr 28, 2025
2c79c92
retro
cbellot000 Apr 28, 2025
da54727
Merge branch 'master' into bug/scripting_name
PProfizi Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ansys/dpf/core/available_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,8 @@ def __repr__(self):
@property
def name(self):
"""Result operator."""
if hasattr(self, "properties") and "scripting_name" in self._properties.keys():
name = self.properties["scripting_name"]
if self._properties and "scripting_name" in self._properties.keys():
name = self._properties["scripting_name"]
elif self.operator_name in _result_properties:
name = _result_properties[self.operator_name]["scripting_name"]
else:
Expand Down
12 changes: 11 additions & 1 deletion tests/test_resultinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import pytest

from ansys import dpf
from ansys.dpf.core import Model
from ansys.dpf.core import Model, examples
from conftest import (
SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_5_0,
SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_6_0,
Expand Down Expand Up @@ -303,3 +303,13 @@ def test_result_info_add_result(model):
dimensions=None,
description="description",
)


@pytest.mark.skipif(
not SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_8_0, reason="Available for servers >=8.0"
)
def test_scripting_name():
model = Model(examples.download_all_kinds_of_complexity_modal())
scripting_names = [res.name for res in model.metadata.result_info]
assert "nmisc" in scripting_names
assert "smisc" in scripting_names
Loading