Skip to content

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Jun 9, 2022

Adding concurrency to workflow runs so that a commit to a PR will run the associated workflows while cancelling the ones still running from the previous commit. Same for pushes to tagged branches.

Also adding back the feature issue template. Apparently having a custom bug.yml meant the organization's template for feature was not used either.

PProfizi added 2 commits June 9, 2022 14:45
…sh to a tagged branch runs the workflow while cancelling the already running ones for the same workflow and PR/tag.
@PProfizi PProfizi added bug Something isn't working enhancement New feature or request CI/CD Related to CI/CD labels Jun 9, 2022
@PProfizi PProfizi self-assigned this Jun 9, 2022
@PProfizi PProfizi removed bug Something isn't working enhancement New feature or request labels Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #262 (14c981d) into master (b305f87) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   85.76%   85.76%           
=======================================
  Files          52       52           
  Lines        5704     5704           
=======================================
  Hits         4892     4892           
  Misses        812      812           

@PProfizi PProfizi requested review from anslpa and cbellot000 June 9, 2022 13:24
- master
- "release*"

concurrency:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi what do that mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbellot000

When a concurrent job or workflow is queued, if another job or workflow using the same concurrency group in the repository is in progress, the queued job or workflow will be pending. Any previously pending job or workflow in the concurrency group will be canceled. To also cancel any currently running job or workflow in the same concurrency group, specify cancel-in-progress: true.

see here
It means committing to your PR will cancel an already running workflow for the same PR.
When you work like me and make frequent commits, you often get the same workflow running multiple times in parallel, once for every commit, instead of just for the latest commit.

@PProfizi PProfizi merged commit 0495078 into master Jun 13, 2022
@PProfizi PProfizi deleted the ci/add_concurrency branch June 13, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related to CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants