Skip to content

Ci/add concurrency-add back feature template #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Ci/add concurrency-add back feature template #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c39a20
Add concurrency to workflows so that a new commit to a PR or a new pu…
PProfizi Jun 9, 2022
7aa5d4f
Add back the feature issue template
PProfizi Jun 9, 2022
14c981d
Steps for implementing the feature is no longer required.
PProfizi Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/ISSUE_TEMPLATE/feature.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: 💡 New feature
description: Enhancements to the code
title: "Add ..."
labels: ["enhancement"]
assignees: [""]

body:

- type: markdown
attributes:
value: '# 📝 **New Feature**'

- type: textarea
id: feature-description
attributes:
label: Description of the feature
placeholder: Describe what feature you devised and why it is useful for the project
validations:
required: true

- type: markdown
attributes:
value: '# 💡 **Implementation**'

- type: textarea
id: implementation-description
attributes:
label: Steps for implementing the feature
placeholder: Describe how this new feature can be implemented
validations:
required: false

- type: markdown
attributes:
value: '# 🔗 **References**'

- type: textarea
id: references
attributes:
label: Useful links and references
placeholder: A list of links and references to help when implementing the feature
validations:
required: false
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ on:
- master
- "release*"

concurrency:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi what do that mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbellot000

When a concurrent job or workflow is queued, if another job or workflow using the same concurrency group in the repository is in progress, the queued job or workflow will be pending. Any previously pending job or workflow in the concurrency group will be canceled. To also cancel any currently running job or workflow in the same concurrency group, specify cancel-in-progress: true.

see here
It means committing to your PR will cancel an already running workflow for the same PR.
When you work like me and make frequent commits, you often get the same workflow running multiple times in parallel, once for every commit, instead of just for the latest commit.

group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
PYANSYS_OFF_SCREEN: True
DPF_PORT: 32772
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/style.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ on:
- master
- "release*"

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
build:
runs-on: ubuntu-20.04
Expand Down