fix: keep import of BaseServer in server.py #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

PProfizi merged 6 commits into main from fix/server_base_in_server.py

Oct 1, 2025

Contributor

PProfizi commented Oct 1, 2025

This was removed during of modification of typing but should be kept for backward compatibility of imports.


          fix: keep import of ServerBase in server.py

bc88f34

PProfizi requested a review from cbellot000

October 1, 2025 08:16

PProfizi self-assigned this

PProfizi commented

View reviewed changes

src/ansys/dpf/core/server.py Outdated Show resolved Hide resolved


          Update src/ansys/dpf/core/server.py

eca1aa4

PProfizi changed the title ~~fix: keep import of ServerBase in server.py~~ fix: keep import of BaseServer in server.py

PProfizi commented

View reviewed changes

src/ansys/dpf/core/server.py Outdated Show resolved Hide resolved


          Fix QA

d484b21

PProfizi commented

View reviewed changes

src/ansys/dpf/core/server.py Show resolved Hide resolved


          Update src/ansys/dpf/core/server.py

0c0ccfc

cbellot000 approved these changes

View reviewed changes

codecov bot commented Oct 1, 2025 •

edited

Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.25%. Comparing base (1e18868) to head (c68cab6).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2646       +/-   ##
===========================================
+ Coverage   46.34%   84.25%   +37.91%     
===========================================
  Files          92       92               
  Lines       10819    10855       +36     
===========================================
+ Hits         5014     9146     +4132     
+ Misses       5805     1709     -4096

PProfizi commented

View reviewed changes

src/ansys/dpf/core/server.py Outdated Show resolved Hide resolved


          Update src/ansys/dpf/core/server.py

b1851a9

PProfizi commented

View reviewed changes

src/ansys/dpf/core/server.py Outdated Show resolved Hide resolved


          Update src/ansys/dpf/core/server.py

c68cab6

PProfizi merged commit 2427af6 into main

42 of 43 checks passed

PProfizi deleted the fix/server_base_in_server.py branch

October 1, 2025 09:54

Contributor

github-actions bot commented Oct 1, 2025

Some tests with 'continue-on-error: true' have failed:

PyDPF-Post API tests on ubuntu-latest

Created by continue-on-error-comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet