-
Notifications
You must be signed in to change notification settings - Fork 23
Update generated code for DPF 261_daily on main #2725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,950 @@ | |||
| """ | |||
| markdown_latex_example | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PProfizi Will be interesting to see how is this one rendered in the pydpf-core doc!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PProfizi I'd say it is good at 80%, with some issues like this one:

Still in my opinion not a blocker to merge. We can focus on this in the future. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rafacanton thanks yeah the point is to fix this going forward, but this is not stopping the update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we can already see what the issue is, and seeing this was exactly the point:
our toolchain here supports dollar delimiters but not bracket/parentheses ones.
You can see the lines are duplicated, the first renders correctly, the second does not.
I'll also check the python docstring rendering in API reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can then also check how it renders in the Framework doc, and in Mechanical... etc.
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2725 +/- ##
=======================================
Coverage 84.41% 84.41%
=======================================
Files 92 92
Lines 10900 10900
=======================================
Hits 9201 9201
Misses 1699 1699 |
An update of generated code has been triggered either manually or by an update in the dpf-standalone repository.