Skip to content

Conversation

@PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Aug 8, 2022

The goal is to first add a manually triggered workflow for testing PyDPF-Post.
The manually triggered action offers to select the Core branch on which to run the workflow.
The PyDPF-Post branch name to test against can be given as input and defaults to "master".
This is to test the workflow and later integrate it in regular testing.
This needs to be merged in master before it can be tested.
See:
https://levelup.gitconnected.com/how-to-manually-trigger-a-github-actions-workflow-4712542f1960

@PProfizi PProfizi added the CI/CD Related to CI/CD label Aug 8, 2022
@PProfizi PProfizi self-assigned this Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #389 (95fea53) into master (9e65d3a) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   86.30%   86.65%   +0.34%     
==========================================
  Files          61       61              
  Lines        6697     6697              
==========================================
+ Hits         5780     5803      +23     
+ Misses        917      894      -23     

@PProfizi PProfizi marked this pull request as ready for review August 8, 2022 16:47
@@ -0,0 +1,78 @@
name: PyDPF-Post testing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi could we not use the action already written in the post? It looks like the same thing.
Using something like:

  - name: "Test"
    uses: pyansys/pydpf-post/test-post@v1.0
    with:
      python-version: ${{ matrix.python-version }}
      ANSYS_VERSION: ${{env.ANSYS_VERSION}}
      PACKAGE_NAME: ${{env.PACKAGE_NAME}}
      PyDPF-Post_branch: 'master'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbellot000 I wanted to minimize the use of external actions first for easier debugging, but yes a composite action could definitely be used, although there is none in the Post repo right now.

@PProfizi PProfizi merged commit 7e4941f into master Aug 9, 2022
@PProfizi PProfizi deleted the ci/retro/add_pydpfpost_testing branch August 9, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related to CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants