-
Notifications
You must be signed in to change notification settings - Fork 20
CI: Adding artifact attestations and fix warnings related to coverage upload #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
+ Coverage 70.60% 70.71% +0.11%
==========================================
Files 224 224
Lines 40286 40286
==========================================
+ Hits 28442 28487 +45
+ Misses 11844 11799 -45 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @ecoussoux-ansys
I think you are missing the attestation generation from the build jobs (to be added through input attest-provenance: true). Pay attention to the permission required when doing this change. I left a comment on the release job.
This PR provides fixes for #1595 and #1596.
The warnings related to coverage upload reported in #1595 should be suppressed by fixing the directory / output file definitions for the
htmlandxmlreports in the "Create coverage files" steps of the linux unit and system tests jobs of the CI (both grpc and dotnet). That way, the coverage files will be properly discovered by the subsequent steps of the test jobs in charge of uploading the reports.The artifact attestations and the associated release note comments are enabled using the option
add-artifact-attestation-notes: truewithin theansys/actions/release-github(see documentation on the action here).Close #1595.
Close #1596.