Skip to content

Conversation

@ecoussoux-ansys
Copy link
Contributor

This PR provides fixes for #1595 and #1596.

The warnings related to coverage upload reported in #1595 should be suppressed by fixing the directory / output file definitions for the html and xml reports in the "Create coverage files" steps of the linux unit and system tests jobs of the CI (both grpc and dotnet). That way, the coverage files will be properly discovered by the subsequent steps of the test jobs in charge of uploading the reports.

The artifact attestations and the associated release note comments are enabled using the option add-artifact-attestation-notes: true within the ansys/actions/release-github (see documentation on the action here).

Close #1595.
Close #1596.

@ecoussoux-ansys ecoussoux-ansys self-assigned this Oct 23, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Oct 23, 2025
svandenb-dev
svandenb-dev previously approved these changes Oct 23, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.71%. Comparing base (518d344) to head (adcf176).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1601      +/-   ##
==========================================
+ Coverage   70.60%   70.71%   +0.11%     
==========================================
  Files         224      224              
  Lines       40286    40286              
==========================================
+ Hits        28442    28487      +45     
+ Misses      11844    11799      -45     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ecoussoux-ansys
I think you are missing the attestation generation from the build jobs (to be added through input attest-provenance: true). Pay attention to the permission required when doing this change. I left a comment on the release job.

@ecoussoux-ansys ecoussoux-ansys merged commit 4971ce3 into main Oct 24, 2025
80 of 83 checks passed
@ecoussoux-ansys ecoussoux-ansys deleted the ci/issues-1595-1596 branch October 24, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Add attestation artifact and associated release note comments CI: Fix warnings related to coverage upload

5 participants