Skip to content

Conversation

@hui-zhou-a
Copy link
Collaborator

@hui-zhou-a hui-zhou-a commented Nov 24, 2025

closes #1633

@github-actions github-actions bot added the testing Anything related to testing label Nov 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.52%. Comparing base (7e4c078) to head (b3b6a7e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1670      +/-   ##
==========================================
+ Coverage   66.38%   66.52%   +0.13%     
==========================================
  Files         228      228              
  Lines       41297    41252      -45     
==========================================
+ Hits        27417    27441      +24     
+ Misses      13880    13811      -69     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

svandenb-dev
svandenb-dev previously approved these changes Nov 24, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev changed the title FIX;: gRPC boundaries FIX: gRPC boundaries Nov 24, 2025
svandenb-dev
svandenb-dev previously approved these changes Nov 24, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added maintenance Package and maintenance related ci/cd labels Nov 25, 2025
hui-zhou-a and others added 2 commits November 25, 2025 23:13
# Conflicts:
#	.github/workflows/ci_cd.yml
#	tests/system/test_edb_configuration_2p0.py
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit cdb12ba into main Nov 27, 2025
31 checks passed
@svandenb-dev svandenb-dev deleted the fix-grpc-boundaries branch November 27, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd maintenance Package and maintenance related testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement model extents in grpc

5 participants