REFACTOR: Refactor and aligned pinpair model#1883
Merged
svandenb-dev merged 11 commits intomainfrom Mar 8, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (68.84%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
+ Coverage 70.20% 70.28% +0.07%
==========================================
Files 261 261
Lines 42416 42460 +44
==========================================
+ Hits 29779 29843 +64
+ Misses 12637 12617 -20 🚀 New features to boost your workflow:
|
deprecation of edb port creations test fix
deprecation of edb port creations test fix
# Conflicts: # tests/system/test_edb.py
github-actions
bot
added
documentation
svandenb-dev
approved these changes
Mar 8, 2026
Collaborator
svandenb-dev
left a comment
svandenb-dev
left a comment
There was a problem hiding this comment.
LGTM after fixing circular import in grpc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now PinPairModel and PinPair are aligned between the two codes