Merged
Conversation
Samuelopez-ansys
previously approved these changes
Mar 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
+ Coverage 70.20% 70.23% +0.03%
==========================================
Files 261 261
Lines 42416 42416
==========================================
+ Hits 29779 29792 +13
+ Misses 12637 12624 -13 🚀 New features to boost your workflow:
|
Samuelopez-ansys
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the downloads module and improves test coverage.
Changes
The download logic in
downloads.pyhas been reworked to useansys-tools-commonas the underlying download manager, replacing the previous custom implementation. This simplifies the codebase and reduces maintenance overhead.A new
test_downloads.pyfile provides unit tests for the download functions, including validation that deprecated functions properly emit warnings.The
test_utils.pyfile was moved fromtests/utils/totests/unit/to run with units tests. This was not tested in CI previously