Skip to content

FIX: Downloads features#1885

Merged
maxcapodi78 merged 6 commits intomainfrom
fix/downloads-features
Mar 6, 2026
Merged

FIX: Downloads features#1885
maxcapodi78 merged 6 commits intomainfrom
fix/downloads-features

Conversation

@SMoraisAnsys
Copy link
Collaborator

Summary

This PR refactors the downloads module and improves test coverage.

Changes

The download logic in downloads.py has been reworked to use ansys-tools-common as the underlying download manager, replacing the previous custom implementation. This simplifies the codebase and reduces maintenance overhead.

A new test_downloads.py file provides unit tests for the download functions, including validation that deprecated functions properly emit warnings.

The test_utils.py file was moved from tests/utils/ to tests/unit/ to run with units tests. This was not tested in CI previously

@github-actions github-actions bot added the testing Anything related to testing label Mar 6, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.23%. Comparing base (5cbae21) to head (b56d4a7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1885      +/-   ##
==========================================
+ Coverage   70.20%   70.23%   +0.03%     
==========================================
  Files         261      261              
  Lines       42416    42416              
==========================================
+ Hits        29779    29792      +13     
+ Misses      12637    12624      -13     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxcapodi78 maxcapodi78 merged commit 09d7a1f into main Mar 6, 2026
24 of 25 checks passed
@maxcapodi78 maxcapodi78 deleted the fix/downloads-features branch March 6, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants