Skip to content

FIX: issue 1939 fix grpc Terminal not set as reference causing random failure on SIwave#1944

Merged
svandenb-dev merged 6 commits intomainfrom
issue#1939-fix-ref-terminal-causing-random-failure-on-siwave
Apr 1, 2026
Merged

FIX: issue 1939 fix grpc Terminal not set as reference causing random failure on SIwave#1944
svandenb-dev merged 6 commits intomainfrom
issue#1939-fix-ref-terminal-causing-random-failure-on-siwave

Conversation

@svandenb-dev
Copy link
Copy Markdown
Collaborator

This PR is addressing issue #1939 found by a user where some methods have hard coded is_ref=False. These terminals are functional but according to the users, this is causing random failure when importing EDB in Siwave. Some voltage source or Current source might be ignored during import. Making sure that negative terminal is always set as reference is resolving this failure.

closes #1939

@svandenb-dev svandenb-dev self-assigned this Mar 22, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.91%. Comparing base (5cbae21) to head (d79e04f).
⚠️ Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1944      +/-   ##
==========================================
+ Coverage   70.20%   70.91%   +0.70%     
==========================================
  Files         261      263       +2     
  Lines       42416    42884     +468     
==========================================
+ Hits        29779    30411     +632     
+ Misses      12637    12473     -164     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svandenb-dev svandenb-dev enabled auto-merge (squash) March 24, 2026 12:54
Copy link
Copy Markdown
Collaborator

@ecoussoux-ansys ecoussoux-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes that cover everything the user had reported 👍
I just left 2 minor comments if you'd like to check.

Also, for your info: On line 970 of source_excitations.py, there is a call to PadstackInstanceTerminal.create() very similar to the one you updated in _create_terminal_on_pins() (line 1252) which (I believe) is explicitly for creating negative terminal but where is_ref is still set to False. Just mentioning in case it would make sense to update this parameter in this other call as well.

Comment thread src/pyedb/grpc/database/source_excitations.py Outdated
Comment thread src/pyedb/grpc/database/source_excitations.py Outdated
Co-authored-by: Edouard Coussoux <edouard.coussoux@ansys.com>
…ing-random-failure-on-siwave' into issue#1939-fix-ref-terminal-causing-random-failure-on-siwave
@svandenb-dev svandenb-dev merged commit 069f632 into main Apr 1, 2026
61 of 65 checks passed
@svandenb-dev svandenb-dev deleted the issue#1939-fix-ref-terminal-causing-random-failure-on-siwave branch April 1, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reference Terminal Missing is_ref=True Flag

5 participants