FIX: issue 1939 fix grpc Terminal not set as reference causing random failure on SIwave#1944
Merged
svandenb-dev merged 6 commits intomainfrom Apr 1, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
==========================================
+ Coverage 70.20% 70.91% +0.70%
==========================================
Files 261 263 +2
Lines 42416 42884 +468
==========================================
+ Hits 29779 30411 +632
+ Misses 12637 12473 -164 🚀 New features to boost your workflow:
|
ecoussoux-ansys
previously approved these changes
Mar 24, 2026
Collaborator
ecoussoux-ansys
left a comment
There was a problem hiding this comment.
Thanks for the changes that cover everything the user had reported 👍
I just left 2 minor comments if you'd like to check.
Also, for your info: On line 970 of source_excitations.py, there is a call to PadstackInstanceTerminal.create() very similar to the one you updated in _create_terminal_on_pins() (line 1252) which (I believe) is explicitly for creating negative terminal but where is_ref is still set to False. Just mentioning in case it would make sense to update this parameter in this other call as well.
Co-authored-by: Edouard Coussoux <edouard.coussoux@ansys.com>
…ing-random-failure-on-siwave' into issue#1939-fix-ref-terminal-causing-random-failure-on-siwave
maxcapodi78
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is addressing issue #1939 found by a user where some methods have hard coded is_ref=False. These terminals are functional but according to the users, this is causing random failure when importing EDB in Siwave. Some voltage source or Current source might be ignored during import. Making sure that negative terminal is always set as reference is resolving this failure.
closes #1939