Skip to content

FIX: Wave port terminal fixed issue #1909#1945

Merged
svandenb-dev merged 12 commits intomainfrom
wave-port-terminal-fixed
Apr 2, 2026
Merged

FIX: Wave port terminal fixed issue #1909#1945
svandenb-dev merged 12 commits intomainfrom
wave-port-terminal-fixed

Conversation

@svandenb-dev
Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev commented Mar 22, 2026

This PR is fixing Wave port and Vertical Gap ports with grpc. It also fixes issue #1909

closes #1909
closes #1787

@svandenb-dev svandenb-dev self-assigned this Mar 22, 2026
@github-actions github-actions bot added the testing Anything related to testing label Mar 22, 2026
@svandenb-dev svandenb-dev changed the title FIX: Wave port terminal fixed FIX: Wave port terminal fixed issue #1909 Mar 22, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 22, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.81%. Comparing base (5cbae21) to head (e4c9ff2).
⚠️ Report is 61 commits behind head on main.

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1945       +/-   ##
===========================================
- Coverage   70.20%   45.81%   -24.40%     
===========================================
  Files         261      263        +2     
  Lines       42416    43009      +593     
===========================================
- Hits        29779    19704    -10075     
- Misses      12637    23305    +10668     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svandenb-dev svandenb-dev enabled auto-merge (squash) March 24, 2026 08:00
maxcapodi78
maxcapodi78 previously approved these changes Apr 1, 2026
# Conflicts:
#	src/pyedb/grpc/database/terminal/edge_terminal.py
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity . -2 duplication

Metric Results
Complexity 0
Duplication -2

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@svandenb-dev svandenb-dev merged commit b9ab7ef into main Apr 2, 2026
41 of 45 checks passed
@svandenb-dev svandenb-dev deleted the wave-port-terminal-fixed branch April 2, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal.is_wave_port always returning True in grpc Bug located in grpc layout_obj.py

4 participants