Skip to content

FIX: Issue#1900 padstacks def#1948

Merged
svandenb-dev merged 8 commits intomainfrom
issue#1900-padstacks-def
Apr 1, 2026
Merged

FIX: Issue#1900 padstacks def#1948
svandenb-dev merged 8 commits intomainfrom
issue#1900-padstacks-def

Conversation

@svandenb-dev
Copy link
Copy Markdown
Collaborator

this PR is fixing issue #1900 when user defines padstacks definition without layers (e.g. only a hole) definition were not returned by edb.padstacks.definition manager.

closes #1900

@svandenb-dev svandenb-dev self-assigned this Mar 22, 2026
@github-actions github-actions bot added testing Anything related to testing grpc-transition Changes that need to be included in gRPC transition labels Mar 22, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.73%. Comparing base (5cbae21) to head (3899241).
⚠️ Report is 47 commits behind head on main.

❌ Your patch status has failed because the patch coverage (78.57%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
+ Coverage   70.20%   70.73%   +0.53%     
==========================================
  Files         261      263       +2     
  Lines       42416    42888     +472     
==========================================
+ Hits        29779    30338     +559     
+ Misses      12637    12550      -87     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svandenb-dev svandenb-dev merged commit e35e0f7 into main Apr 1, 2026
25 checks passed
@svandenb-dev svandenb-dev deleted the issue#1900-padstacks-def branch April 1, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot find all padstack definition using edb.padstacks.definitions.items()

4 participants