Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1966 +/- ##
==========================================
+ Coverage 70.20% 70.65% +0.44%
==========================================
Files 261 263 +2
Lines 42416 43031 +615
==========================================
+ Hits 29779 30402 +623
+ Misses 12637 12629 -8 🚀 New features to boost your workflow:
|
…logged-with-grpc' into issue#1963-material-falls-error-logged-with-grpc
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Thanks for the changes, I added minor comments.
Could you also clarify why you are returning None in some cases and 0 in others? Would it make sense to align the "strategy" to always return None if no value /model was defined ?
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
…logged-with-grpc' into issue#1963-material-falls-error-logged-with-grpc
Returning 0.0 is made to preserve DotNet and Config file compatibility with providing default value. Few properties are returning None since they are optional, I mean by optional not necessarily defined. Like dc_conductivity assumes dielectric model is defined prio accessing this attribute. |
This PR is resolving internal material properties failure. These errors were harmless but could lead to confusion. This was also pointed by users and adressing issue #1963.
grpc material has now safe guards with:
closes #1963