Skip to content

FIX: remove dotnetcore2#1972

Merged
svandenb-dev merged 9 commits intomainfrom
remove-dotnetcore2
Mar 27, 2026
Merged

FIX: remove dotnetcore2#1972
svandenb-dev merged 9 commits intomainfrom
remove-dotnetcore2

Conversation

@hui-zhou-a
Copy link
Copy Markdown
Collaborator

@hui-zhou-a hui-zhou-a commented Mar 27, 2026

dotnetcore2 is not compatible with 251 and beyond. The user needs to install .NET in Linux manually.

closes #1973

@github-actions github-actions bot added maintenance Package and maintenance related dependencies Related with project dependencies labels Mar 27, 2026
svandenb-dev
svandenb-dev previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the testing Anything related to testing label Mar 27, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.91%. Comparing base (5cbae21) to head (832a758).
⚠️ Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
+ Coverage   70.20%   70.91%   +0.70%     
==========================================
  Files         261      263       +2     
  Lines       42416    42885     +469     
==========================================
+ Hits        29779    30412     +633     
+ Misses      12637    12473     -164     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 5e32ef5 into main Mar 27, 2026
27 of 28 checks passed
@svandenb-dev svandenb-dev deleted the remove-dotnetcore2 branch March 27, 2026 13:15
drewm102 added a commit that referenced this pull request Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies maintenance Package and maintenance related testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dotnetcore2==3.1.23 dependency

5 participants