Skip to content

FIX: issue#1979 set solder ball material#1982

Merged
svandenb-dev merged 3 commits intomainfrom
issue#1979-set-solder-ball-material
Apr 2, 2026
Merged

FIX: issue#1979 set solder ball material#1982
svandenb-dev merged 3 commits intomainfrom
issue#1979-set-solder-ball-material

Conversation

@svandenb-dev
Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev commented Apr 2, 2026

This PR is addressing issue #1979 entered by a user. The material definition was missing with

  • set_solder_ball() method from Components manager
  • Component.solder_ball_material did have setter with DotNet.

This PR is fixing all these issues and is adding tests.

This PR is also fixing issue #1983

closes #1979
closes #1983

@svandenb-dev svandenb-dev self-assigned this Apr 2, 2026
@svandenb-dev svandenb-dev requested a review from hui-zhou-a April 2, 2026 12:02
@github-actions github-actions bot added testing Anything related to testing grpc-transition Changes that need to be included in gRPC transition labels Apr 2, 2026
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 18.51852% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.85%. Comparing base (5cbae21) to head (92ad08c).
⚠️ Report is 61 commits behind head on main.

❌ Your patch status has failed because the patch coverage (18.51%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1982       +/-   ##
===========================================
- Coverage   70.20%   48.85%   -21.36%     
===========================================
  Files         261      263        +2     
  Lines       42416    43032      +616     
===========================================
- Hits        29779    21022     -8757     
- Misses      12637    22010     +9373     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svandenb-dev svandenb-dev enabled auto-merge (squash) April 2, 2026 12:39
@svandenb-dev svandenb-dev merged commit 711829a into main Apr 2, 2026
28 checks passed
@svandenb-dev svandenb-dev deleted the issue#1979-set-solder-ball-material branch April 2, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grpc set_solder_ball does not take correct solder height Does PyEDB provide solder ball material parameters

4 participants