Skip to content

FIX: Coverage rects and bugs in functions#2007

Merged
gkorompi merged 26 commits intomainfrom
coverage_rects
Apr 10, 2026
Merged

FIX: Coverage rects and bugs in functions#2007
gkorompi merged 26 commits intomainfrom
coverage_rects

Conversation

@gkorompi
Copy link
Copy Markdown
Collaborator

@gkorompi gkorompi commented Apr 7, 2026

closes #2006

@gkorompi gkorompi changed the title Coverage rects FIX: Coverage rects Apr 7, 2026
@gkorompi gkorompi changed the title FIX: Coverage rects FIX: Coverage rects and bugs in functions Apr 7, 2026
@github-actions github-actions bot added the testing Anything related to testing label Apr 7, 2026
Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create should work

Comment thread tests/system/test_edb_modeler.py Outdated
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 7, 2026

Not up to standards ⛔

🔴 Issues 4 minor

Alerts:
⚠ 4 issues (≤ 0 issues of at least minor severity)

Results:
4 new issues

Category Results
Documentation 4 minor

View in Codacy

🟢 Metrics 0 complexity · -2 duplication

Metric Results
Complexity 0
Duplication -2

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.28%. Comparing base (5cbae21) to head (b913b21).
⚠️ Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2007      +/-   ##
==========================================
+ Coverage   70.20%   70.28%   +0.07%     
==========================================
  Files         261      264       +3     
  Lines       42416    43198     +782     
==========================================
+ Hits        29779    30361     +582     
- Misses      12637    12837     +200     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gkorompi gkorompi requested a review from svandenb-dev April 7, 2026 08:42
@gkorompi gkorompi enabled auto-merge (squash) April 8, 2026 06:02
@gkorompi gkorompi self-assigned this Apr 8, 2026
svandenb-dev
svandenb-dev previously approved these changes Apr 10, 2026
Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	tests/system/test_edb_modeler.py
Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkorompi gkorompi merged commit d3033b3 into main Apr 10, 2026
24 of 25 checks passed
@gkorompi gkorompi deleted the coverage_rects branch April 10, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix bugs in rect prims in grpc. Add test coverage

4 participants