Skip to content

FEAT: RF trace taper#2008

Merged
svandenb-dev merged 18 commits intomainfrom
refactor-test-database-geometry
Apr 9, 2026
Merged

FEAT: RF trace taper#2008
svandenb-dev merged 18 commits intomainfrom
refactor-test-database-geometry

Conversation

@hui-zhou-a
Copy link
Copy Markdown
Collaborator

No description provided.

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 7, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 6 complexity · 8 duplication

Metric Results
Complexity 6
Duplication 8

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@github-actions github-actions bot added testing Anything related to testing grpc-transition Changes that need to be included in gRPC transition labels Apr 7, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 95.78947% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.20%. Comparing base (5cbae21) to head (af43894).
⚠️ Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2008      +/-   ##
==========================================
- Coverage   70.20%   70.20%   -0.01%     
==========================================
  Files         261      264       +3     
  Lines       42416    43196     +780     
==========================================
+ Hits        29779    30325     +546     
- Misses      12637    12871     +234     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hui-zhou-a
Copy link
Copy Markdown
Collaborator Author

close #2009

Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete and should contain also create_taper method for grpc.
Entering the issue and skipping test for grpc is not enough.

@hui-zhou-a
Copy link
Copy Markdown
Collaborator Author

@svandenb-dev it cannot be implemented before #2005 is fixed.

@hui-zhou-a hui-zhou-a requested a review from svandenb-dev April 7, 2026 11:45
@svandenb-dev
Copy link
Copy Markdown
Collaborator

Please check and wait PR #2015 is merged so you can complete this PR.

Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait PR#2015 is validated and merged and add grpc method

@hui-zhou-a
Copy link
Copy Markdown
Collaborator Author

hui-zhou-a commented Apr 8, 2026

@svandenb-dev can you merge #2012?

Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit e30a4a9 into main Apr 9, 2026
61 of 65 checks passed
@svandenb-dev svandenb-dev deleted the refactor-test-database-geometry branch April 9, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants