Skip to content

FIX: guard gRPC layout terminal enumeration against null terminals#2040

Merged
svandenb-dev merged 2 commits intomainfrom
fix/grpc-terminal-enumeration-null-guard-upstream
Apr 15, 2026
Merged

FIX: guard gRPC layout terminal enumeration against null terminals#2040
svandenb-dev merged 2 commits intomainfrom
fix/grpc-terminal-enumeration-null-guard-upstream

Conversation

@pl170491
Copy link
Copy Markdown
Collaborator

@pl170491 pl170491 commented Apr 15, 2026

Summary

  • guard gRPC layout terminal enumeration against None and invalid terminal objects
  • add focused unit coverage for invalid terminal entries and enumeration failure

Notes

  • This replaces the earlier fork-based PR so CI can run without fork OIDC/provenance restrictions.

closes #2028

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 15, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 5 complexity · 0 duplication

Metric Results
Complexity 5
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.33%. Comparing base (5cbae21) to head (134f3a3).
⚠️ Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2040      +/-   ##
==========================================
- Coverage   70.20%   69.33%   -0.88%     
==========================================
  Files         261      264       +3     
  Lines       42416    43366     +950     
==========================================
+ Hits        29779    30066     +287     
- Misses      12637    13300     +663     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev enabled auto-merge (squash) April 15, 2026 21:03
@svandenb-dev svandenb-dev merged commit 1f032ab into main Apr 15, 2026
28 checks passed
@svandenb-dev svandenb-dev deleted the fix/grpc-terminal-enumeration-null-guard-upstream branch April 15, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gRPC terminal enumeration crashes on null terminal objects

4 participants