chore: Restructure some grpc services. - #5192
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
…pyfluent into maint/application_runtime
prmukherj
marked this pull request as ready for review
June 24, 2026 16:38
prmukherj
requested review from
hpohekar,
mayankansys,
mkundu1 and
seanpearsonuk
June 24, 2026 16:38
Collaborator
Author
|
Nightly tests are all passing. |
prmukherj
marked this pull request as ready for review
July 2, 2026 12:38
mkundu1
approved these changes
Jul 6, 2026
seanpearsonuk
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The grpc service layer and python implementation layers were closely couple together for the grpc services.
Change Summary
Cleanly segregate the grpc service layer and python implementation layer for 5 grpc services.
Implemented a factory layer which takes care of version checking logic, etc.
Impact
Users to see a cleaner and well documented interface.
_grpc_services
services
_grpc_serviceshandles all version checking, etc.From FluentConnection or session layer: