Skip to content

chore: Restructure some grpc services. - #5192

Merged
prmukherj merged 50 commits into
mainfrom
maint/application_runtime
Jul 8, 2026
Merged

chore: Restructure some grpc services.#5192
prmukherj merged 50 commits into
mainfrom
maint/application_runtime

Conversation

@prmukherj

@prmukherj prmukherj commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Context

The grpc service layer and python implementation layers were closely couple together for the grpc services.

Change Summary

Cleanly segregate the grpc service layer and python implementation layer for 5 grpc services.
Implemented a factory layer which takes care of version checking logic, etc.

Impact

Users to see a cleaner and well documented interface.


  • Design:

_grpc_services


- application_runtime_service_v0.py / application_runtime_service.py
- health_check_service_v0.py / health_check_service.py
- reduction_service_v0.py / reduction_service.py
- scheme_interpreter_service_v0.py / scheme_interpreter_service.py
- settings_service_v0.py / settings_service.py

services


- application_runtime (abstract_application_runtime)
	- ApplicationRuntime (application_runtime_service)
	- ApplicationRuntimeV261 (application_runtime_service_v0)
	- ApplicationRuntimeV252 (application_runtime_service_v0, scheme_interpreter_service_v0)
	- ApplicationRuntimeOld (scheme_interpreter_service_v0)

- health_check (abstract_health_check)
	- HealthCheck (health_check_service / health_check_service_v0)

- reduction (abstract_reduction)
	- Reduction (reduction_service / reduction_service_v0)

- scheme_interpreter (abstract_scheme_interpreter)
	- SchemeInterpreter (scheme_interpreter_service / scheme_interpreter_service_v0)

- settings (abstract_settings)
	- Settings (settings_service)
	- SettingsV261 (settings_service_v0, application_runtime_service_v0, scheme_interpreter_service_v0)
	- SettingsV251 (settings_service_v0, scheme_interpreter_service_v0)
  • The Factory layer in _grpc_services handles all version checking, etc.

From FluentConnection or session layer:


self._grpc_factory = GRPCFactory(channel, metadata, error_state)
self.application_runtime = self._grpc_factory.application_runtime
self.health_check = self._grpc_factory.health_check
self.reduction = self._grpc_factory.reduction
self.scheme = self._grpc_factory.scheme_interpreter
self.settings = self._grpc_factory.settings

@github-actions github-actions Bot added the enhancement Improve any current implemented feature label Jun 16, 2026
@codacy-production

codacy-production Bot commented Jun 16, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@prmukherj
prmukherj marked this pull request as ready for review June 24, 2026 16:38
Comment thread src/ansys/fluent/core/abstract_application_runtime.py Outdated
Comment thread src/ansys/fluent/core/application_runtime.py Outdated
Comment thread src/ansys/fluent/core/application_runtime.py Outdated
Comment thread src/ansys/fluent/core/services/application_runtime.py Outdated
Comment thread src/ansys/fluent/core/application_runtime.py Outdated
Comment thread src/ansys/fluent/core/session.py Outdated
Comment thread src/ansys/fluent/core/session.py
Comment thread src/ansys/fluent/core/session.py
@prmukherj

Copy link
Copy Markdown
Collaborator Author

Nightly tests are all passing.
https://github.com/ansys/pyfluent/actions/runs/28530589368

@prmukherj
prmukherj marked this pull request as ready for review July 2, 2026 12:38
Comment thread src/ansys/fluent/core/services/abstract_settings.py
Comment thread src/ansys/fluent/core/_grpc_services/__init__.py
Comment thread src/ansys/fluent/core/_grpc_services/__init__.py Outdated
Comment thread src/ansys/fluent/core/_grpc_services/__init__.py Outdated
@github-actions github-actions Bot added maintenance General maintenance of the repo (libraries, cicd, etc) dependencies Related to dependencies labels Jul 7, 2026
@prmukherj
prmukherj merged commit 4f82bfb into main Jul 8, 2026
61 of 62 checks passed
@prmukherj
prmukherj deleted the maint/application_runtime branch July 8, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related to dependencies enhancement Improve any current implemented feature maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants