fix: Deprecation behavior. - #5322
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
prmukherj
marked this pull request as ready for review
August 18, 2026 14:49
prmukherj
requested review from
hpohekar,
mayankansys,
mkundu1 and
seanpearsonuk
August 18, 2026 14:49
prmukherj
commented
Aug 18, 2026
mkundu1
approved these changes
Aug 18, 2026
mayankansys
approved these changes
Aug 18, 2026
|
|
||
| from ansys.fluent.core.examples import download_file, path | ||
| from ansys.fluent.core.filereader.casereader import CaseReader | ||
| from ansys.fluent.core.filereader.case_file import CaseFile as CaseReader |
Collaborator
There was a problem hiding this comment.
Suggested change
| from ansys.fluent.core.filereader.case_file import CaseFile as CaseReader | |
| from ansys.fluent.core.filereader.case_file import CaseFile |
| assert len(all_vars) == pytest.approx(9000, 20) | ||
|
|
||
| # CaseFile comparison, note that the PyFluent work dir is not necessarily the same as the Fluent work dir | ||
| case = CaseReader(case_file_name=path(case_path)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| case = CaseFile(case_file_name=path(case_path)) |
Comment on lines
42
to
44
| from ansys.fluent.core._grpc_services.object_model_service_v0 import ( | ||
| _convert_value_to_variant, | ||
| _convert_variant_to_value, |
Collaborator
There was a problem hiding this comment.
The old version should keep the version suffix; the new version can be imported directly without suffix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
An incorrect import path was used for
convert_variant_to_valuefor 27R1 tests.Change Summary
Updated import paths.
Resolved a few deprecated imports.