fix: issue with interruptible commands on interrupt. - #5339
Merged
Conversation
Up to standards ✅🟢 Issues
|
prmukherj
commented
Aug 21, 2026
mkundu1
approved these changes
Aug 21, 2026
Collaborator
|
@prmukherj Isn't this all done and ready? |
prmukherj
marked this pull request as ready for review
August 21, 2026 14:16
Collaborator
Author
Ready now @seanpearsonuk |
seanpearsonuk
approved these changes
Aug 21, 2026
prmukherj
enabled auto-merge (squash)
August 21, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Calling
session.settings.solution.run_calculation.interrupt()from within a SolverEvent.ITERATION_ENDED callback causes the concurrently-blockingrun_calculation.iterate()gRPC call on the main thread to raise RuntimeError: () rather than returning normally — even though Fluent itself stops the solver cleanly and prints Done. Operation stopped.The consequence is that any code following the iterate() call (writing case files, post-processing, etc.) is silently skipped. This makes event-driven convergence monitoring unreliable in practice.
Change Summary
RuntimeError: (), and if so swallow the error.Rationale
Ideally Fluent should not raise an error in this case, but currently it is interrupting cleanly and raising an error with blank message unlike in other cases where the message strings are populated appropriately. Hence using that to handle this particular bug.
Impact
Users will not face the situation as described, and will be able to develop similar workflows seamlessly.