Jnovak/client refresh failure #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix client_id missing fix client_secret missing log the call has been retried
FedericoNegri
approved these changes
Jul 18, 2023
Contributor
FedericoNegri
left a comment
FedericoNegri
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Code is updated to support auto_refresh for clients other than rep_cli. Some items were not passed to the auto refresh authentication command that broke the process when a client other than rep_cli was being used. Similar changes have already been made in the evaluator code to support other clients configurations for the evaluator.
This was tested by setting a short token lifespan in keycloak and allowing it to refresh through the process automatically.
Checklist
Please complete the following checklist before submitting your pull request: