Skip to content

Jnovak/client refresh failure #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Jnovak/client refresh failure #194

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2b66a3
Fix auto refresh token code:
Buzz1167 Jul 11, 2023
74514ce
pass more options to authenticate
Buzz1167 Jul 11, 2023
328c8c0
Local fixes for pre-commit
Buzz1167 Jul 11, 2023
fa71489
Merge branch 'main' into jnovak/client_refresh_failure
FedericoNegri Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions ansys/rep/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,13 @@ def _auto_refresh_token(self, response, *args, **kwargs):
response.status_code == 401
and self._unauthorized_num_retry < self._unauthorized_max_retry
):
log.info(f"401 authorization error: trying to get a new access token.")
log.info(f"401 authorization error: Trying to get a new access token.")
self._unauthorized_num_retry += 1
self.refresh_access_token()
response.request.headers.update(
{"Authorization": self.session.headers["Authorization"]}
)
log.debug(f"Retrying request with updated access token.")
return self.session.send(response.request)

self._unauthorized_num_retry = 0
Expand All @@ -157,18 +158,27 @@ def _auto_refresh_token(self, response, *args, **kwargs):
def refresh_access_token(self):
"""Request a new access token"""
if self.grant_type == "client_credentials":
# Its not recommended to give refresh tokens to client_credentials grant types
# as per OAuth 2.0 RFC6749 Section 4.4.3, so handle these specially...
tokens = authenticate(
url=self.auth_url or self.rep_url,
realm=self.realm,
grant_type="client_credentials",
scope=self.scope,
client_id=self.client_id,
client_secret=self.client_secret,
grant_type=self.grant_type,
)
else:
# Other workflows for authentication generally support refresh_tokens
tokens = authenticate(
url=self.auth_url or self.rep_url,
refresh_token=self.refresh_token,
username=self.username,
realm=self.realm,
grant_type="refresh_token",
scope=self.scope,
client_id=self.client_id,
client_secret=self.client_secret,
username=self.username,
refresh_token=self.refresh_token,
)
self.access_token = tokens["access_token"]
self.refresh_token = tokens.get("refresh_token", None)
Expand Down