Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/669.documentation.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix: updated get_stackup_props() to have improveStackupModelEnabled in the response
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ classifiers = [
]

dependencies = [
"ansys-api-sherlock==0.1.51",
"ansys-api-sherlock==0.1.52",
"grpcio>=1.17, <1.68.0",
"protobuf>=3.20",
"pydantic>=2.9.2",
Expand Down
1 change: 1 addition & 0 deletions src/ansys/sherlock/core/types/stackup_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ def __init__(self, properties: SherlockStackupService_pb2.GetStackupPropsRespons
self.ctez = properties.ctEz
self.exy = properties.exy
self.ez = properties.ez
self.improve_stackup_model_enabled = properties.improveStackupModelEnabled
38 changes: 28 additions & 10 deletions tests/test_stackup.py
Original file line number Diff line number Diff line change
Expand Up @@ -611,16 +611,34 @@ def helper_test_get_stackup_props(stackup):
"Main Board",
)

assert (
stackup_properties.board_dimension == "190.3171 x 114.3076 mm [7.4928 x 4.5003 in]"
), "Board dimension"
assert stackup_properties.board_thickness == "2.091 mm [82.3 mil]", "Board thickness"
assert stackup_properties.density == "2.0264 g/cc", "Density"
assert stackup_properties.conductor_layers_cnt == "6", "Conductor layers count"
assert stackup_properties.ctexy == "18.618 ppm/C", "CTExy"
assert stackup_properties.ctez == "60.821 ppm/C", "CTEz"
assert stackup_properties.exy == "25,420 MPa", "Exy"
assert stackup_properties.ez == "6,939 MPa", "Ez"
if stackup_properties.improve_stackup_model_enabled:
assert (
stackup_properties.board_dimension
== "190.3171 x 114.3076 mm [7.4928 x 4.5003 in]"
), "Board dimension"
assert (
stackup_properties.board_thickness == "2.091 mm [82.3 mil]"
), "Board thickness"
assert stackup_properties.density == "2.0264 g/cc", "Density"
assert stackup_properties.conductor_layers_cnt == "6", "Conductor layers count"
assert stackup_properties.ctexy == "18.556 ppm/C", "CTExy"
assert stackup_properties.ctez == "60.821 ppm/C", "CTEz"
assert stackup_properties.exy == "24,865 MPa", "Exy"
assert stackup_properties.ez == "6,939 MPa", "Ez"
else:
assert (
stackup_properties.board_dimension
== "190.3171 x 114.3076 mm [7.4928 x 4.5003 in]"
), "Board dimension"
assert (
stackup_properties.board_thickness == "2.091 mm [82.3 mil]"
), "Board thickness"
assert stackup_properties.density == "2.0264 g/cc", "Density"
assert stackup_properties.conductor_layers_cnt == "6", "Conductor layers count"
assert stackup_properties.ctexy == "18.618 ppm/C", "CTExy"
assert stackup_properties.ctez == "60.821 ppm/C", "CTEz"
assert stackup_properties.exy == "25,420 MPa", "Exy"
assert stackup_properties.ez == "6,939 MPa", "Ez"
except SherlockGetLayerCountError as e:
pytest.fail(str(e))

Expand Down
Loading