Skip to content

Conversation

@jwinkle8
Copy link
Contributor

Resolves #14
This change also brings the removal of undesired "#noqa" comments

Resolves #14
This change also brings the removal of undesired "#noqa" comments
@jwinkle8 jwinkle8 requested a review from a team as a code owner August 28, 2023 19:41
@github-actions github-actions bot added docs:api Related to API documentation docs:examples Related to documentation examples enhancement General improvements to existing features tests Related with improvements of the test suite labels Aug 28, 2023
Copy link
Contributor

@duposyl duposyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jorgepiloto jorgepiloto added docs:examples Related to documentation examples docs:api Related to API documentation and removed docs:examples Related to documentation examples docs:api Related to API documentation labels Aug 29, 2023
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, @jwinkle8. Thanks for the huge effort on modernizing these names.

I just manually triggered the CI to render the API docs just to verify that everything renders as expected.

@jorgepiloto jorgepiloto merged commit 4e7f045 into main Aug 29, 2023
@jorgepiloto jorgepiloto deleted the feat/enumeration-renames branch August 29, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:api Related to API documentation docs:examples Related to documentation examples enhancement General improvements to existing features tests Related with improvements of the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Naming enums into macros

5 participants