Skip to content

Conversation

@jorgepiloto
Copy link
Member

@jorgepiloto jorgepiloto commented Nov 21, 2022

Fix #41 and fix #42 by migrating all requirements to the pyproject.toml and using PyAnsys actions.

@github-actions github-actions bot added dependencies Related with project dependencies maintenance Generic maintenance related labels Nov 21, 2022
@jorgepiloto jorgepiloto changed the title MAINT: migrate requirements to pyproject.toml MAINT: migrate requirements to pyproject.toml and use pyansys/actions Nov 21, 2022
@github-actions github-actions bot added the docs Issues related to documentation label Nov 21, 2022
@jorgepiloto jorgepiloto force-pushed the maint/full-pyproject-migration branch 8 times, most recently from 9b0dba1 to 8ab4ea6 Compare November 22, 2022 09:14
@jorgepiloto jorgepiloto force-pushed the maint/full-pyproject-migration branch from 8ab4ea6 to 5189afd Compare November 30, 2022 08:47
@jorgepiloto jorgepiloto force-pushed the maint/full-pyproject-migration branch from 241b4cd to 148f18f Compare November 30, 2022 08:50
@jorgepiloto jorgepiloto force-pushed the maint/full-pyproject-migration branch 3 times, most recently from d746e21 to 3bf99ce Compare November 30, 2022 09:23
@jorgepiloto
Copy link
Member Author

Let me decouple the tests from the style just for debugging purposes. I want to make sure that the arguments are passed properly to pytest.

@jorgepiloto jorgepiloto force-pushed the maint/full-pyproject-migration branch 8 times, most recently from 5ccaf88 to 46f8e6d Compare November 30, 2022 10:19
@jorgepiloto jorgepiloto force-pushed the maint/full-pyproject-migration branch 2 times, most recently from 0a02fa7 to 8e06b11 Compare November 30, 2022 10:20
@jorgepiloto jorgepiloto marked this pull request as ready for review November 30, 2022 10:20
@jorgepiloto jorgepiloto requested a review from a team November 30, 2022 10:20
Copy link
Contributor

@duposyl duposyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for consolidating the CI/CD workflow to use shared pyansys/actions! This is going to help a lot with future maintenance.

@jorgepiloto jorgepiloto merged commit ea77879 into main Nov 30, 2022
@jorgepiloto jorgepiloto deleted the maint/full-pyproject-migration branch November 30, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies docs Issues related to documentation maintenance Generic maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate requirements/ to pyproject.toml Update CI/CD to use pyansys/actions

3 participants