Skip to content

fix: code style to match pyflakes and flake8-pyi #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 31, 2025
Merged

fix: code style to match pyflakes and flake8-pyi #603

merged 8 commits into from
Jan 31, 2025

Conversation

@jorgepiloto
Copy link
Member

@jorgepiloto jorgepiloto commented Jan 24, 2025

This pull-request is a continuation of #220. It enables the pyflakes rule in Ruff.

@github-actions github-actions bot added the fix Pull requests related to resolving problems or errors label Jan 24, 2025
@jorgepiloto jorgepiloto changed the title fix: code style to match pyflakes fix: code style to match pyflakes and flake8-pyi Jan 24, 2025
@jorgepiloto jorgepiloto added tests:skip Skip tests runs in CI/CD docs:skip Skip documentation runs in CI/CD labels Jan 24, 2025
@jorgepiloto
Copy link
Member Author

jorgepiloto commented Jan 24, 2025

Skipping tests and docs for the moment.

jorgepiloto
jorgepiloto commented Jan 24, 2025
View reviewed changes
jorgepiloto
jorgepiloto commented Jan 24, 2025
View reviewed changes
jorgepiloto
jorgepiloto commented Jan 24, 2025
View reviewed changes
jorgepiloto
jorgepiloto commented Jan 24, 2025
View reviewed changes
jorgepiloto
jorgepiloto commented Jan 24, 2025
View reviewed changes
Copy link
Member Author

@jorgepiloto jorgepiloto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some comments explaining the modified files. Last failures are located in the ansys/stk/core/__init__.py file due to the lack of a __all__ declaration.

@jorgepiloto jorgepiloto marked this pull request as ready for review January 30, 2025 09:37
@jorgepiloto jorgepiloto requested a review from a team as a code owner January 30, 2025 09:37
jwinkle8
jwinkle8 reviewed Jan 30, 2025
View reviewed changes
jorgepiloto
jorgepiloto commented Jan 30, 2025
View reviewed changes
@jorgepiloto jorgepiloto requested a review from jwinkle8 January 30, 2025 18:00
MaxJPRey
MaxJPRey approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jwinkle8
jwinkle8 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@jwinkle8 jwinkle8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and changes are synced on our side, though doing so required running isort on the API, which modifies the order of imports on a number of files. I will add these modifications in a future PR.

jorgepiloto
jorgepiloto commented Jan 31, 2025
View reviewed changes
@jorgepiloto jorgepiloto merged commit c206c11 into main Jan 31, 2025
13 checks passed
@jorgepiloto jorgepiloto deleted the fix/pyflakes branch January 31, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duposyl duposyl duposyl left review comments

@jwinkle8 jwinkle8 jwinkle8 approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

Assignees

No one assigned

Labels

docs:skip Skip documentation runs in CI/CD fix Pull requests related to resolving problems or errors tests:skip Skip tests runs in CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jorgepiloto @duposyl @jwinkle8 @MaxJPRey