-
Notifications
You must be signed in to change notification settings - Fork 4
CI: set up self-hosted runner #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
09c7b40 to
cd97069
Compare
|
@jorgepiloto Looks good to me. I am fine with the current approach, and I thought about a small improvement that we could do now or later: One small improvement would be to use a multi-stage build for the What do you think? |
|
I think this is a great suggestion, @duposyl. It will help us to easily maintain all these images. |
|
@jorgepiloto, thanks for the update. It is nice that installing the system dependencies and building openssl is now in one common place for all the python versions. Another possible further improvement would be something similar to this for the Python specific version dockerfile (for instance for stk-engine-py38/Dockerfile): That way the temporary build files and build dependencies do not get included in the final image used for testing the API. Now if you think this is overkill, I am fine with what you currently have too. |
duposyl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for putting this together!
c516dff to
951ba5e
Compare
951ba5e to
16703de
Compare
|
Great work @jorgepiloto . |
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Fixes #62 by using a custom self-hosted runner for running the required jobs in the CI/CD pipeline.
The reason why the container should have an image per Python version is that, right now, PySTK is not a remote Python API. It does not connect to a server living inside the container. Hence, we are forced to use the Python inside the container to execute a Python script.
Another possibility is to install multiple Python versions in the contianer. The official docker images for STK allow to do so.
Then, it should be a matter of starting the container, enabling the desired Python version and running the CI/CD commands. This also saves disk space in the machine.
This situation will solve as the project evolves.