query: reset mergeQuery iterator in Evaluate#123
Merged
zhengchun merged 1 commit intoJul 8, 2026
Conversation
A "//name" step compiles to a mergeQuery, whose Select only rebuilds its node list when the cached iterator is nil. Every other node-set query clears that field in Evaluate; mergeQuery did not, so re-evaluating one compiled expression against a different document reused the previous document's nodes. Fixes antchfx#122 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//namesteps compile to amergeQuery, and itsSelectonly rebuilds the result list whenm.iterator == nil. Every other node-set query (childQuery, descendantQuery, ancestorQuery, and so on) clears that field inEvaluate, butmergeQuery.Evaluatedidn't, so re-evaluating a compiled expression against a different document reused the node list from the previous one.This adds the missing
m.iterator = nilso mergeQuery matches the other queries. Regression test evaluates//bar[true()] and count(//foo)=0against two documents and back, which returned true on the third pass before the fix.Fixes #122