Handle PHP 8.1 "never" return type #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.1 added a "never" return type that indicates that the function will never return, and raises a fatal error if such a function includes a `return`. We need to detect and handle such functions in a similar manner as we handle "void". Also it turns out that the error handling for a "void" redefinition trying to return a value was broken, giving an error like ``` Fatal error: Uncaught Error: Undefined constant "thrownew\Patchwork\Exceptions\NonNullToVoid" in file line # ``` so I added a test for that too and adjusted the condense function to collapse whitespace to a single space instead of stripping it completely.
|
Hey! After running into the same issue, Google led me to this issue / PR. I can confirm this PR solved the described issue on the repo I've been working on! 👍 |
antecedent
approved these changes
Sep 18, 2023
Owner
|
This is now live in 2.1.26. My apologies for the delay, and thanks to @anomiex for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 added a "never" return type that indicates that the function will never return, and raises a fatal error if such a function includes a
return. We need to detect and handle such functions in a similar manner as we handle "void".Also it turns out that the error handling for a "void" redefinition trying to return a value was broken, giving an error like
so I added a test for that too and adjusted the condense function to collapse whitespace to a single space instead of stripping it completely.
Fixes #140