getCachedPath(): improve test #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test as added in PR 170 did not actually hit the PHP 8.4 deprecation notice, which - while it is a useful test for other reasons - makes it an ineffective test for safeguarding the fix from 170, which was about preventing the PHP 8.4 deprecation notice. This commit updates the test to ensure the fix for the PHP 8.4 deprecation notice is now properly safeguarded. This can be verified by undoing the change to the `src/CodeManipulation.php` file from 170 and running this test on PHP 8.4. The test will fail and show the deprecation notice. When the change from 170 is re-applied, the test will pass without the deprecation notice. Includes adding the `===DONE===` markers for consistency with the other tests.
Collaborator
Author
|
@antecedent Might be good to tag a new patch version once this PR has been merged as I can imagine other projects working on their PHP 8.4 readiness running into the deprecation notice. |
Owner
|
Oops. Great that you caught this, @jrfnl. And yes, I agree that a new patch version is a good idea. I will tag one. |
antecedent
approved these changes
Dec 11, 2024
Collaborator
Author
|
Thanks @antecedent! (also for the release) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test as added in PR #170 did not actually hit the PHP 8.4 deprecation notice, which - while it is a useful test for other reasons - makes it an ineffective test for safeguarding the fix from #170, which was about preventing the PHP 8.4 deprecation notice.
This commit updates the test to ensure the fix for the PHP 8.4 deprecation notice is now properly safeguarded.
This can be verified by undoing the change to the
src/CodeManipulation.phpfile from #170 and running this test on PHP 8.4. The test will fail and show the deprecation notice. When the change from #170 is re-applied, the test will pass without the deprecation notice.Includes adding the
===DONE===markers for consistency with the other tests.