Skip to content

fix allocator lifetime issue#107

Merged
LHT129 merged 6 commits into
mainfrom
fix-allocator-lifetime-issue
Nov 4, 2024
Merged

fix allocator lifetime issue#107
LHT129 merged 6 commits into
mainfrom
fix-allocator-lifetime-issue

Conversation

@inabao

@inabao inabao commented Oct 31, 2024

Copy link
Copy Markdown
Collaborator

fixed: #105

…th index

Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao
inabao requested a review from jiaweizone as a code owner October 31, 2024 04:00
@inabao
inabao requested review from LHT129 and wxyucs October 31, 2024 04:00
@inabao inabao self-assigned this Oct 31, 2024
@inabao inabao added the kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 label Oct 31, 2024
@wxyucs
wxyucs removed their request for review October 31, 2024 07:31
@wxyucs

wxyucs commented Oct 31, 2024

Copy link
Copy Markdown
Collaborator

@LHT129 please check this pull request about allocator lifecycle

Comment thread src/default_allocator.h Outdated
Comment thread src/index/hnsw.cpp Outdated
Comment thread src/safe_allocator.h Outdated
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>

@LHT129 LHT129 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/safe_allocator.h
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>

@jiaweizone jiaweizone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129
LHT129 merged commit 185eccf into main Nov 4, 2024
@LHT129
LHT129 deleted the fix-allocator-lifetime-issue branch November 4, 2024 06:22
Roxanne0321 pushed a commit to Roxanne0321/vsag that referenced this pull request Mar 3, 2025
- fix allocator lifespan issue causing incorrect memory deallocation with index

Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Co-authored-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129 pushed a commit that referenced this pull request May 11, 2026
- fix allocator lifespan issue causing incorrect memory deallocation with index

Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Co-authored-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
- fix allocator lifespan issue causing incorrect memory deallocation with index

Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Co-authored-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Debug mode] if the hnsw index is static, the default allocator may abort()

4 participants