Skip to content

add hgraph param#111

Merged
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:hgraph_params
Nov 6, 2024
Merged

add hgraph param#111
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:hgraph_params

Conversation

@LHT129

@LHT129 LHT129 commented Nov 4, 2024

Copy link
Copy Markdown
Collaborator

issue: #40

  • introduce inner param for inner indexes
  • map the external param to inner
  • add format_map for long string to help reading

@LHT129
LHT129 requested a review from inabao November 4, 2024 09:23
@LHT129 LHT129 self-assigned this Nov 4, 2024
@LHT129
LHT129 requested a review from ShawnShawnYou November 4, 2024 09:23
@LHT129 LHT129 added the kind/feature Brand-new functionality or capabilities 引入全新的功能、新特性或新能力 label Nov 4, 2024
@LHT129
LHT129 force-pushed the hgraph_params branch 3 times, most recently from bde288f to 735c3d7 Compare November 4, 2024 12:28
Comment thread src/index/hgraph_zparameters.cpp Outdated
Comment thread src/index/hgraph_zparameters.cpp Outdated
}
}

const std::unordered_map<std::string, std::vector<std::string>> HgraphParameters::EXTERNAL_MAPPING =

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to L25 ?
let the variables definition precede functions definition

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread src/index/hgraph_zparameters.h Outdated
Comment thread src/index/hgraph_zparameters.h Outdated
Comment thread src/index/hgraph_zparameters.h Outdated
}

void
sync_string_by_json() {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refresh_string ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment thread src/utils.cpp

@jiaweizone jiaweizone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- introduce inner param for inner indexes
- map the exteral param to inner
- add format_map for long string to help reading

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129
LHT129 merged commit 89ae0a6 into antgroup:main Nov 6, 2024
@LHT129
LHT129 deleted the hgraph_params branch January 17, 2025 06:39
Roxanne0321 pushed a commit to Roxanne0321/vsag that referenced this pull request Mar 3, 2025
- introduce inner param for inner indexes
- map the exteral param to inner
- add format_map for long string to help reading

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129 added a commit that referenced this pull request May 11, 2026
- introduce inner param for inner indexes
- map the exteral param to inner
- add format_map for long string to help reading

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
- introduce inner param for inner indexes
- map the exteral param to inner
- add format_map for long string to help reading

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Brand-new functionality or capabilities 引入全新的功能、新特性或新能力 size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants